HyukjinKwon commented on a change in pull request #32394:
URL: https://github.com/apache/spark/pull/32394#discussion_r624883369
##########
File path: core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala
##########
@@ -49,7 +49,11 @@ abstract class BenchmarkBase {
val resultFileName =
s"${this.getClass.getSimpleName.replace("$",
"")}$jdkString$suffix-results.txt"
val prefix = Benchmarks.currentProjectRoot.map(_ + "/").getOrElse("")
- val file = new File(s"${prefix}benchmarks/$resultFileName")
+ val dir = new File(s"${prefix}benchmarks/")
+ if (!dir.exists()) {
+ dir.mkdirs()
Review comment:
My concern is that the benchmark directory is based on jars paths which
are flaky. Might be better to explicitly show.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
