HyukjinKwon commented on pull request #32394: URL: https://github.com/apache/spark/pull/32394#issuecomment-831035088
@srowen and @zhengruifeng FYI from https://github.com/apache/spark/commit/9244066ca69a3fb5d7fe446ce0e19d108892c49d and https://github.com/apache/spark/commit/5b77ebb57ba6edf1f8f4f8e83abef4f9f1ae6175. I think it was perfectly fine without including benchmark results (but codes only) because It was a bit weird to upload the results based on different spec machines. Now there have been some latest changes at #32015 and #32044, and now the PR authors can run the benchmark results in similar specification very easily (https://spark.apache.org/developer-tools.html#github-workflow-benchmarks), and it makes more sense to include benchmark results in a PR :). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
