luhenry commented on a change in pull request #32415:
URL: https://github.com/apache/spark/pull/32415#discussion_r626408304
##########
File path: LICENSE-binary
##########
@@ -456,7 +456,6 @@ org.antlr:ST4
org.antlr:stringtemplate
org.antlr:antlr4-runtime
antlr:antlr
-com.github.fommil.netlib:core
Review comment:
You bring up a good point: `com.github.fommil.netlib` is still a
transient dependency of Spark through `org.scalanlp:breeze`. I already
submitted and merged a PR there to replace the dependency
(https://github.com/scalanlp/breeze/pull/811), but it hasn't been released yet.
For the sake of not regressing performance, let me re-add the dependency on
`com.github.fommil.netlib:all` in `pom.xml` when enabling`-Pnetlib-lgpl` and
leave a comment to explain when we can remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
