fommil edited a comment on pull request #32415: URL: https://github.com/apache/spark/pull/32415#issuecomment-832810727
Perhaps I am misunderstanding the benchmarks, but it looks to me like netlib-java native (unclear which impl you're using, I assume MKL?) DGEMM still dramatically wins over the java impl. If that is the case it seems a big mistake to remove it as an option. Am I missing something here? BTW, to be clear: there is no GPL code in `netlib-java`. The code generators are GPL, but not part of the published artifact. There is an optional dependency on LGPL helpers to extract and load the native JNI binaries that dynamically link to the system impl. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
