attilapiros commented on a change in pull request #31829:
URL: https://github.com/apache/spark/pull/31829#discussion_r628853451
##########
File path:
resource-managers/kubernetes/integration-tests/dev/dev-run-integration-tests.sh
##########
@@ -176,4 +180,4 @@ properties+=(
-Dlog4j.logger.org.apache.spark=DEBUG
)
-$TEST_ROOT_DIR/build/mvn integration-test -f $TEST_ROOT_DIR/pom.xml -pl
resource-managers/kubernetes/integration-tests -am -Pscala-$SCALA_VERSION
-P$HADOOP_PROFILE -Pkubernetes -Pkubernetes-integration-tests ${properties[@]}
+$TEST_ROOT_DIR/build/mvn install -f $TEST_ROOT_DIR/pom.xml -pl
resource-managers/kubernetes/integration-tests $BUILD_DEPENDENCIES_MVN_FLAG
-Pscala-$SCALA_VERSION -P$HADOOP_PROFILE -Pkubernetes
-Pkubernetes-integration-tests ${properties[@]}
Review comment:
I would say this is the orherway around, assuming in both PRs we stick
to `install`.
So when we call `install` in the first PR we could be sure the fresh jars
will be used (even when the artifact we build referencing something outside of
the maven reactor) and when we move to the next PR because of `install` we have
again the fresh jars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
