attilapiros commented on a change in pull request #31829:
URL: https://github.com/apache/spark/pull/31829#discussion_r628853939
##########
File path:
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/backend/minikube/Minikube.scala
##########
@@ -16,100 +16,73 @@
*/
package org.apache.spark.deploy.k8s.integrationtest.backend.minikube
-import java.nio.file.{Files, Paths}
-
-import io.fabric8.kubernetes.client.{ConfigBuilder, DefaultKubernetesClient}
+import io.fabric8.kubernetes.client.Config
+import io.fabric8.kubernetes.client.DefaultKubernetesClient
import org.apache.spark.deploy.k8s.integrationtest.ProcessUtils
import org.apache.spark.internal.Logging
// TODO support windows
private[spark] object Minikube extends Logging {
private val MINIKUBE_STARTUP_TIMEOUT_SECONDS = 60
- private val HOST_PREFIX = "host:"
- private val KUBELET_PREFIX = "kubelet:"
- private val APISERVER_PREFIX = "apiserver:"
- private val KUBECTL_PREFIX = "kubectl:"
- private val KUBECONFIG_PREFIX = "kubeconfig:"
+ private val VERSION_PREFIX = "minikube version: "
+ private val HOST_PREFIX = "host: "
+ private val KUBELET_PREFIX = "kubelet: "
+ private val APISERVER_PREFIX = "apiserver: "
+ private val KUBECTL_PREFIX = "kubectl: "
+ private val KUBECONFIG_PREFIX = "kubeconfig: "
Review comment:
I can revert them but I think this is more clean than polluting each
usage with the extra space. In addition we can use the `split` method (and
getting the second part) instead of the `replace_first` which express our
intention a bit better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
