xkrogen commented on a change in pull request #32388:
URL: https://github.com/apache/spark/pull/32388#discussion_r629507805
##########
File path:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleServiceMetrics.java
##########
@@ -78,7 +82,17 @@ public static void collectMetric(
new ShuffleServiceMetricsInfo(name + "_rate1", "1 minute rate of
timer " + name),
t.getOneMinuteRate())
.addGauge(new ShuffleServiceMetricsInfo(name + "_rateMean", "Mean rate
of timer " + name),
- t.getMeanRate());
+ t.getMeanRate())
+ .addGauge(getMetricsInfoGenericValue(timingName, "max"),
snapshot.getMax())
+ .addGauge(getMetricsInfoGenericValue(timingName, "min"),
snapshot.getMin())
+ .addGauge(getMetricsInfoGenericValue(timingName, "mean"),
snapshot.getMean())
+ .addGauge(getMetricsInfoGenericValue(timingName, "stdDev"),
snapshot.getStdDev());
+ for (int percentile : new int[] { 1, 5, 25, 50, 75, 95, 99 }) {
Review comment:
I added 98th and 99.9th percentiles. Thanks for the input!
One thing that may seem unusual is the low percentiles (1, 5, 25), which
have found useful internally for a getting a better sense of the full range of
timing information. Let me know if you think they are too non-standard to
include here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
