xkrogen commented on a change in pull request #32388:
URL: https://github.com/apache/spark/pull/32388#discussion_r629508528
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockHandler.java
##########
@@ -291,9 +294,18 @@ public ShuffleMetrics() {
allMetrics.put("openBlockRequestLatencyMillis",
openBlockRequestLatencyMillis);
allMetrics.put("registerExecutorRequestLatencyMillis",
registerExecutorRequestLatencyMillis);
allMetrics.put("finalizeShuffleMergeLatencyMillis",
finalizeShuffleMergeLatencyMillis);
+ allMetrics.put("blockTransferRate", blockTransferRate);
allMetrics.put("blockTransferRateBytes", blockTransferRateBytes);
+ allMetrics.put("blockTransferAvgSize_1min", new RatioGauge() {
+ @Override
+ protected Ratio getRatio() {
+ return Ratio.of(
+ blockTransferRateBytes.getOneMinuteRate(),
+ blockTransferRate.getOneMinuteRate());
+ }
+ });
allMetrics.put("registeredExecutorsSize",
- (Gauge<Integer>) () ->
blockManager.getRegisteredExecutorsSize());
+ (Gauge<Integer>) blockManager::getRegisteredExecutorsSize);
Review comment:
You're right, I will revert. It's not needed, just a minor cleanup --
this is more of the "correct" way to pass a method reference (avoid creating an
extra anonymous class just to wrap the method reference in a lambda).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
