Github user aarondav commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5743#discussion_r29452859
  
    --- Diff: 
network/common/src/main/java/org/apache/spark/network/server/StreamManager.java 
---
    @@ -44,6 +46,17 @@
       public abstract ManagedBuffer getChunk(long streamId, int chunkIndex);
     
       /**
    +   * Register the given stream to the associated channel. So these streams 
can be cleaned up later.
    +   */
    +  public void registerChannel(Channel channel, long streamId) { }
    +
    +  /**
    +   * Indicates that the given channel has been terminated. After this 
occurs, we are guaranteed not
    +   * to read from the associated streams again, so any state can be 
cleaned up.
    +   */
    +  public void connectionTerminated(Channel channel) { }
    +
    +  /**
    --- End diff --
    
    Please remove this method, it should no longer be used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to