Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/5743#discussion_r29453281
--- Diff:
network/common/src/main/java/org/apache/spark/network/server/StreamManager.java
---
@@ -44,6 +46,17 @@
public abstract ManagedBuffer getChunk(long streamId, int chunkIndex);
/**
+ * Register the given stream to the associated channel. So these streams
can be cleaned up later.
--- End diff --
Let's beef up the documentation:
Associates a stream with a single client connection, which is guaranteed to
be the only reader of the stream. The getChunk() method will be called serially
on this connection and once the connection is closed, the stream will never be
used again, enabling cleanup.
This must be called before the first getChunk() on the stream, but it may
be invoked multiple times with the same channel and stream id.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
