Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5811#discussion_r29471690
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/commands.scala ---
    @@ -84,8 +84,15 @@ case class SetCommand(
           logWarning(
             s"Property ${SQLConf.Deprecated.MAPRED_REDUCE_TASKS} is 
deprecated, " +
               s"automatically converted to ${SQLConf.SHUFFLE_PARTITIONS} 
instead.")
    -      sqlContext.setConf(SQLConf.SHUFFLE_PARTITIONS, value)
    -      Seq(Row(s"${SQLConf.SHUFFLE_PARTITIONS}=$value"))
    +      if (value == "-1") {
    +        logWarning(
    +          s"Set this property to -1 for automatically determining the 
number of reducers " +
    +            s"is not supported, showing current 
${SQLConf.SHUFFLE_PARTITIONS} instead.")
    --- End diff --
    
    actually can I suggest a small rewording a think is a little clearer?
    
    `Setting this property to -1 for automatically determing the number of 
reducers is not supported.  Ignoring request, and showing  
${SQLConf.SHUFFLE_PARTITIONS} instead`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to