Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5809#discussion_r29472362
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -350,7 +345,6 @@ private class LeastSquaresAggregator(
}
}
lossSum += diff * diff / 2.0
- diffSum += diff
--- End diff --
Basically you're saying this isn't read at all, which seems correct. I
don't know if it's 0? (Haven't thought about it.) The rest looks like style
changes which seems OK, but why remove the `Array` type, but keep the `Long`
type, when you are making the literal a long explicitly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
