viirya commented on a change in pull request #32559:
URL: https://github.com/apache/spark/pull/32559#discussion_r633916177
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubexpressionEliminationSuite.scala
##########
@@ -309,6 +309,22 @@ class SubexpressionEliminationSuite extends SparkFunSuite
with ExpressionEvalHel
CodeGenerator.compile(code)
}
}
+
+ test("SPARK-35410: SubExpr elimination should not include redundant child
exprs " +
+ "for conditional expressions") {
Review comment:
Thanks @Kimahriman. I see. Let me also look at it. As it is
non-conditional case, but looks like the similar case. Let me see if it can be
solved similarly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
