cloud-fan commented on a change in pull request #32488:
URL: https://github.com/apache/spark/pull/32488#discussion_r634400092
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/UnwrapCastInBinaryComparison.scala
##########
@@ -121,6 +129,24 @@ object UnwrapCastInBinaryComparison extends
Rule[LogicalPlan] {
if canImplicitlyCast(fromExp, toType, literalType) =>
simplifyNumericComparison(be, fromExp, toType, value)
+ case in @ In(Cast(fromExp, toType: NumericType, _), list)
+ if list.forall(v =>
+ v.isInstanceOf[Literal] && canImplicitlyCast(fromExp, toType,
v.dataType)
Review comment:
The analyzer makes sure that the list of `In` is already of the same
data type. Here we can simply check
```
list.forall(_.isInstanceOf[Literal]) && canImplicitlyCast(fromExp, toType,
list.head.dataType)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
