HyukjinKwon commented on a change in pull request #32587:
URL: https://github.com/apache/spark/pull/32587#discussion_r635953428
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionInfo.java
##########
@@ -144,6 +155,11 @@ public ExpressionInfo(
this.name + "]. It should be a value in " + validGroups + ";
however, " +
"got [" + group + "].");
}
+ if (!language.isEmpty() && !validLanguages.contains(language)) {
Review comment:
what about: udf, hive and built-in or .. udf (scala), udf (java),
udf(python), hive and built-in?
Yeah, `functionType` sounds better.
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionDescription.java
##########
@@ -112,4 +112,5 @@
String group() default "";
String since() default "";
String deprecated() default "";
+ String language() default "built-in";
Review comment:
Hm, I think it has mixed meanings:
- `built-in` vs `hive`
- `scala` vs `java` vs `python`
Also, is the second classification useful? I thought that it describes which
languages support function APIs in `functions.scala`, `functions.py` and
`functions.R`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
