linhongliu-db commented on a change in pull request #32587:
URL: https://github.com/apache/spark/pull/32587#discussion_r636138804
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionDescription.java
##########
@@ -112,4 +112,5 @@
String group() default "";
String since() default "";
String deprecated() default "";
+ String language() default "built-in";
Review comment:
@HyukjinKwon, thanks for reviewing.
Yes, it has mixed meanings. but the classification should be: `built-in`,
`hive udf`, `spark udf`:
* `built-in` means the functions defined in `functions.scala`,
`functions.py` and `functions.R`
* `hive udf` means the udf created by SQL `CREATE (TEMP)? FUNCTION xxx`
* `spark udf` means the udf created by `spark.udf.register()`,
`spark.udf.registerJava()`, `spark.udf.registerPython()`. and the registered
udfs can use `scala`, `java`, `python` languages.
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionDescription.java
##########
@@ -112,4 +112,5 @@
String group() default "";
String since() default "";
String deprecated() default "";
+ String language() default "built-in";
Review comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
