LuciferYang commented on a change in pull request #32648:
URL: https://github.com/apache/spark/pull/32648#discussion_r637726282
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/EpochTracker.scala
##########
@@ -28,7 +28,7 @@ object EpochTracker {
// update the underlying AtomicLong as it finishes epochs. Other code should
only read the value.
private val currentEpoch: InheritableThreadLocal[AtomicLong] = {
new InheritableThreadLocal[AtomicLong] {
- override protected def childValue(parent: AtomicLong): AtomicLong = {
+ override def childValue(parent: AtomicLong): AtomicLong = {
Review comment:
```
[ERROR] [Error]
/spark/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/EpochTracker.scala:31:
weaker access privileges in overriding
private[package lang] def childValue(x$1:
java.util.concurrent.atomic.AtomicLong): java.util.concurrent.atomic.AtomicLong
(defined in class ThreadLocal)
override should at least be private[lang]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
