LuciferYang commented on a change in pull request #32648:
URL: https://github.com/apache/spark/pull/32648#discussion_r637729610
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala
##########
@@ -509,7 +509,7 @@ case class NoCloseColumnVector(wrapped: ColumnVector)
extends ColumnVector(wrapp
override def getBinary(rowId: Int): Array[Byte] = wrapped.getBinary(rowId)
- override protected def getChild(ordinal: Int): ColumnVector =
wrapped.getChild(ordinal)
+ override def getChild(ordinal: Int): ColumnVector = wrapped.getChild(ordinal)
Review comment:
```
/spark/sql/core/src/test/scala/org/apache/spark/sql/SparkSessionExtensionSuite.scala:512:26
weaker access privileges in overriding
def getChild(x$1: Int): org.apache.spark.sql.vectorized.ColumnVector
(defined in class ColumnVector)
override should be public
override protected def getChild(ordinal: Int): ColumnVector =
wrapped.getChild(ordinal)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
