cloud-fan commented on a change in pull request #32513:
URL: https://github.com/apache/spark/pull/32513#discussion_r638771881
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -74,12 +76,31 @@ class QueryExecution(
sparkSession.sessionState.analyzer.executeAndCheck(logical, tracker)
}
+ // SPARK-35378: Eagerly execute Command
+ // Currently, Command returns GenericInternalRow and some Exec casts the
output
+ // of child plan to UnsafeRow. If we set Command as the child node or sub
query,
+ // then ClassCastException occurs. Such as:
+ // java.lang.ClassCastException
+ // org.apache.spark.sql.catalyst.expressions.GenericInternalRow cannot be
cast to
+ // org.apache.spark.sql.catalyst.expressions.UnsafeRow
+ // So eagerly executes Command and converts the output of it to UnsafeRow.
+ lazy val commandExecuted: LogicalPlan = analyzed transformDown {
+ case c: Command if isExecutingCommand == false =>
Review comment:
This does eagerly execute the commands, but it doesn't solve the cast
issue if commands are nested, e.g. you insert into a table with the result of
SHOW TABLES.
Even if `isExecutingCommand = true`, we should still eagerly execute the
non-root commands, to turn them into `CommandResult` and avoid the cast issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
