cloud-fan commented on a change in pull request #32513:
URL: https://github.com/apache/spark/pull/32513#discussion_r639377680



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -74,12 +76,37 @@ class QueryExecution(
     sparkSession.sessionState.analyzer.executeAndCheck(logical, tracker)
   }
 
+  // SPARK-35378: Eagerly execute Command

Review comment:
       ```
   SPARK-35378: Commands should be executed eagerly so that `sql("INSERT ...")` 
can trigger the
   table insertion immediately without a `.collect()`. We also need to eagerly 
execute non-root commands,
   because many commands return `GenericInternalRow` and can't be put in a 
query plan directly, otherwise
   the query engine may cast `GenericInternalRow` to `UnsafeRow` and fail
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to