sarutak commented on a change in pull request #32652:
URL: https://github.com/apache/spark/pull/32652#discussion_r641893268
##########
File path:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerJDBCIntegrationSuite.scala
##########
@@ -99,6 +99,8 @@ abstract class DockerJDBCIntegrationSuite extends
SharedSparkSession with Eventu
val connectionTimeout = timeout(5.minutes)
val keepContainer =
sys.props.getOrElse("spark.test.docker.keepContainer", "false").toBoolean
+ val removePulledImage =
+ sys.props.getOrElse("spark.test.docker.removePulledImage",
"true").toBoolean
Review comment:
It was `false` at first but after
[discussion](https://github.com/apache/spark/pull/32652#discussion_r639342223),
I changed it to `true`.
non-GA users who have ever run docker integration tests before this change
can have images on their environment so image downloading doesn't happen every
unless they remove images manually everytime.
Or, do you imagine a situation which is possible to cause a problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
