sarutak commented on a change in pull request #32652:
URL: https://github.com/apache/spark/pull/32652#discussion_r641897974
##########
File path:
external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DockerJDBCIntegrationSuite.scala
##########
@@ -99,6 +99,8 @@ abstract class DockerJDBCIntegrationSuite extends
SharedSparkSession with Eventu
val connectionTimeout = timeout(5.minutes)
val keepContainer =
sys.props.getOrElse("spark.test.docker.keepContainer", "false").toBoolean
+ val removePulledImage =
+ sys.props.getOrElse("spark.test.docker.removePulledImage",
"true").toBoolean
Review comment:
To avoid behavior change, it would be better to keep it `false` but
keeping container images in the local repository is side effect and done
implicitly before this change. So I thought it is better do keep the images
only if users can explicitly set the property to `false`.
Any thoughts? @dongjoon-hyun @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
