Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/5743#discussion_r29510283
--- Diff:
network/common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
---
@@ -82,10 +75,8 @@ public void exceptionCaught(Throwable cause) {
@Override
public void channelUnregistered() {
- // Inform the StreamManager that these streams will no longer be read
from.
- for (long streamId : streamIds) {
- streamManager.connectionTerminated(streamId);
- }
+ // Inform the StreamManager that this channel is unregistered.
--- End diff --
nit: I think we can remove this comment, the new code is straightforward
enough.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
