Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/5743#discussion_r29510421
--- Diff:
network/common/src/main/java/org/apache/spark/network/server/TransportRequestHandler.java
---
@@ -102,7 +93,8 @@ public void handle(RequestMessage request) {
private void processFetchRequest(final ChunkFetchRequest req) {
final String client = NettyUtils.getRemoteAddress(channel);
- streamIds.add(req.streamChunkId.streamId);
+
+ streamManager.registerChannel(channel, req.streamChunkId.streamId);
--- End diff --
As we don't know from this point in the code whether the registerChannel
method will throw an exception, let's move it inside the try-catch for the
getChunk(). Otherwise we could leave a message unresponded-to, which would be
bad.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
