Ngone51 commented on pull request #32790:
URL: https://github.com/apache/spark/pull/32790#issuecomment-855527325


   
https://github.com/apache/spark/blob/b8740a1d1ef6f7e08873a37c7ff1b4e3980679f0/core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala#L877-L881
   ^^^ If `BlockManagerInfo.externalShuffleServiceBlockStatus` only handles RDD 
blocks, shall we use `if (blockId.isRDD && blockStatus.diskSize > 0)` instead 
to avoid mistakenly leak for other block types?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to