Ngone51 edited a comment on pull request #32790: URL: https://github.com/apache/spark/pull/32790#issuecomment-855582413
> @Ngone51 currently I cannot see a leak here but I am open to change this if it is proven to be exists. It doesn't exist currently. I'm proposing a safer way actually. And I think it's more readable. Looking at `if (!blockId.isBroadcast && blockStatus.diskSize > 0)` makes me think it handle all block types excepts the broadcast block. However, looking at `removeBlock`, it shows it only cleans rdd blocks indeed. So it makes me think whether we missed other block types. Fortunately, we only have broadcast block and rdd block here so it won't leak anything. But the current situation might be broken if we added a new block in the future and forget to update accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
