viirya commented on a change in pull request #32828:
URL: https://github.com/apache/spark/pull/32828#discussion_r647946628
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
##########
@@ -274,6 +274,9 @@ class SymmetricHashJoinStateManager(
if (valuePairAtMaxIndex != null) {
keyWithIndexToValue.put(currentKey, index,
valuePairAtMaxIndex.value,
valuePairAtMaxIndex.matched)
+ } else {
+ logWarning(s"`keyWithIndexToValue` returns a null value for index
${numValues - 1} " +
Review comment:
Less cryptic approach might be to project unsafe row to internal row.
Although it needs extra projection, but I think this is less likely case to
happen. So maybe we don't need to worry too much about performance.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
