HeartSaVioR commented on a change in pull request #32828:
URL: https://github.com/apache/spark/pull/32828#discussion_r647971086



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala
##########
@@ -274,6 +274,9 @@ class SymmetricHashJoinStateManager(
           if (valuePairAtMaxIndex != null) {
             keyWithIndexToValue.put(currentKey, index, 
valuePairAtMaxIndex.value,
               valuePairAtMaxIndex.matched)
+          } else {
+            logWarning(s"`keyWithIndexToValue` returns a null value for index 
${numValues - 1} " +

Review comment:
       Oh that's a brilliant idea. Just to make sure we don't miss anything, 
how it will be printed out? Probably testing with simple but composite row 
(like row having String, Int, Timestamp, etc.) would be good.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to