dongjoon-hyun commented on a change in pull request #32962:
URL: https://github.com/apache/spark/pull/32962#discussion_r654728013
##########
File path: python/pyspark/util.py
##########
@@ -305,35 +307,22 @@ def inheritable_thread_target(f):
>>> Thread(target=inheritable_thread_target(target_func)).start() #
doctest: +SKIP
"""
from pyspark import SparkContext
- if os.environ.get("PYSPARK_PIN_THREAD", "false").lower() == "true":
- # Here's when the pinned-thread mode (PYSPARK_PIN_THREAD) is on.
- sc = SparkContext._active_spark_context
- # Get local properties from main thread
- properties = sc._jsc.sc().getLocalProperties().clone()
+ if os.environ.get("PYSPARK_PIN_THREAD", "true").lower() == "true":
Review comment:
This seems to be the change of default value when `PYSPARK_PIN_THREAD`
is not set. Do we need to mention this in the PR description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
