HyukjinKwon commented on a change in pull request #32962:
URL: https://github.com/apache/spark/pull/32962#discussion_r654728144
##########
File path: python/pyspark/util.py
##########
@@ -305,35 +307,22 @@ def inheritable_thread_target(f):
>>> Thread(target=inheritable_thread_target(target_func)).start() #
doctest: +SKIP
"""
from pyspark import SparkContext
- if os.environ.get("PYSPARK_PIN_THREAD", "false").lower() == "true":
- # Here's when the pinned-thread mode (PYSPARK_PIN_THREAD) is on.
- sc = SparkContext._active_spark_context
- # Get local properties from main thread
- properties = sc._jsc.sc().getLocalProperties().clone()
+ if os.environ.get("PYSPARK_PIN_THREAD", "true").lower() == "true":
Review comment:
Oh yeah, it was a mistake from #32429, and actually I meant it by:
> #32429 missed one place at inheritable_thread_target
(https://github.com/apache/spark/blob/master/python/pyspark/util.py#L308).
Let me me more explicit on that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
