pan3793 commented on a change in pull request #32998: URL: https://github.com/apache/spark/pull/32998#discussion_r655231497
########## File path: .gitignore ########## @@ -15,8 +15,8 @@ .ensime_cache/ .ensime_lucene .generated-mima* -# The star is required for further !.idea/ to work, see https://git-scm.com/docs/gitignore -.idea/* Review comment: It's because that `.idea/vcs.xml` already tracked by git. After removing `*`, when you add some rules like `!.idea/icon.png`, it will not pickup by git. ########## File path: .gitignore ########## @@ -15,8 +15,8 @@ .ensime_cache/ .ensime_lucene .generated-mima* -# The star is required for further !.idea/ to work, see https://git-scm.com/docs/gitignore -.idea/* Review comment: `-f` make sense to me. ########## File path: .gitignore ########## @@ -15,8 +15,8 @@ .ensime_cache/ .ensime_lucene .generated-mima* -# The star is required for further !.idea/ to work, see https://git-scm.com/docs/gitignore -.idea/* +.idea/ +# SPARK-35223: Add IssueNavigationLink to make IDEA support hyperlink on JIRA Ticket and GitHub PR on Git plugin. !.idea/vcs.xml python/.idea Review comment: +1 for comments of `-f` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
