c21 commented on a change in pull request #32944:
URL: https://github.com/apache/spark/pull/32944#discussion_r662817747
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala
##########
@@ -1885,4 +1885,54 @@ class AdaptiveQueryExecSuite
}
}
}
+
+ test("SPARK-35794: Allow custom plugin for cost evaluator") {
+ CostEvaluator.instantiate(
+ classOf[SimpleShuffleSortCostEvaluator].getCanonicalName,
spark.sparkContext.getConf)
+ intercept[IllegalArgumentException] {
+ CostEvaluator.instantiate(
+ classOf[InvalidCostEvaluator].getCanonicalName,
spark.sparkContext.getConf)
+ }
+
+ withSQLConf(
+ SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",
+ SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> "80") {
+ val query = "SELECT * FROM testData join testData2 ON key = a where
value = '1'"
+
+ withSQLConf(SQLConf.ADAPTIVE_CUSTOM_COST_EVALUATOR_CLASS.key ->
+
"org.apache.spark.sql.execution.adaptive.SimpleShuffleSortCostEvaluator") {
Review comment:
@cloud-fan - this evaluator does not change plan, and to be the same
with the builtin evaluator for this query. Do we want to come up a different
one here? I think this just validates the custom evaluator works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
