dtarima commented on a change in pull request #33251:
URL: https://github.com/apache/spark/pull/33251#discussion_r667233077
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/DownloadFile.java
##########
@@ -27,12 +27,10 @@
*/
public interface DownloadFile {
/**
- * Delete the file.
- *
- * @return <code>true</code> if and only if the file or directory is
- * successfully deleted; <code>false</code> otherwise
+ * Creates a new {@link DownloadFileDeleter} for the underlying resources of
+ * the {@link DownloadFile}.
*/
- boolean delete();
+ DownloadFileDeleter deleter();
Review comment:
Missed the comment and now it's already outdated, but just for the
record...
I tried to use `Function` first, but it turned out to be ugly due to the mix
of Java and Scala.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
