Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/5729#discussion_r29599426
--- Diff: core/src/main/scala/org/apache/spark/rdd/RDDOperationScope.scala
---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.rdd
+
+import java.util.concurrent.atomic.AtomicInteger
+
+import com.fasterxml.jackson.annotation.JsonIgnore
+import com.fasterxml.jackson.databind.ObjectMapper
+import com.fasterxml.jackson.module.scala.DefaultScalaModule
+
+import org.apache.spark.SparkContext
+
+/**
+ * A general, named code block representing an operation that instantiates
RDDs.
+ *
+ * All RDDs instantiated in the corresponding code block will store a
pointer to this object.
+ * Examples include, but will not be limited to, existing RDD operations,
such as textFile,
+ * reduceByKey, and treeAggregate.
+ *
+ * An operation scope may be nested in other scopes. For instance, a SQL
query may enclose
+ * scopes associated with the public RDD APIs it uses under the hood.
+ *
+ * There is no particular relationship between an operation scope and a
stage or a job.
+ * A scope may live inside one stage (e.g. map) or span across multiple
jobs (e.g. take).
+ */
+private[spark] class RDDOperationScope(
--- End diff --
Can we add a unit test that will break if we change this class in a way
where the object mapper no longer works for legacy JSON data? I.e. test the
conversion from JSON on some hard coded JSON. From what I can tell right now
there is no test that covers this, since all tests of the object mapping from
JSON use input data that is also generated from the mapper.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
