Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/5729#discussion_r29599528
--- Diff:
core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala ---
@@ -0,0 +1,205 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.ui.scope
+
+import scala.collection.mutable
+import scala.collection.mutable.ListBuffer
+
+import org.apache.spark.Logging
+import org.apache.spark.scheduler.StageInfo
+import org.apache.spark.storage.StorageLevel
+
+/**
+ * A representation of a generic cluster graph used for storing
information on RDD operations.
+ *
+ * Each graph is defined with a set of edges and a root cluster, which may
contain children
+ * nodes and children clusters. Additionally, a graph may also have edges
that enter or exit
+ * the graph from nodes that belong to adjacent graphs.
+ */
+private[ui] case class RDDOperationGraph(
+ edges: Seq[RDDOperationEdge],
+ outgoingEdges: Seq[RDDOperationEdge],
+ incomingEdges: Seq[RDDOperationEdge],
+ rootCluster: RDDOperationCluster)
+
+/** A node in an RDDOperationGraph. This represents an RDD. */
+private[ui] case class RDDOperationNode(id: Int, name: String, cached:
Boolean)
+
+/**
+ * A directed edge connecting two nodes in an RDDOperationGraph.
+ * This represents an RDD dependency.
+ */
+private[ui] case class RDDOperationEdge(fromId: Int, toId: Int)
+
+/**
+ * A cluster that groups nodes together in an RDDOperationGraph.
+ *
+ * This represents any grouping of RDDs, including operation scopes (e.g.
textFile, flatMap),
+ * stages, jobs, or any higher level construct. A cluster may be nested
inside of other clusters.
+ */
+private[ui] class RDDOperationCluster(val id: String, val name: String) {
+ private val _childrenNodes = new ListBuffer[RDDOperationNode]
+ private val _childrenClusters = new ListBuffer[RDDOperationCluster]
+
+ def childrenNodes: Seq[RDDOperationNode] = _childrenNodes.iterator.toSeq
--- End diff --
I think grammatically it should be `childNodes` - right? Not sure you
pluralize children here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
