cloud-fan commented on a change in pull request #31522:
URL: https://github.com/apache/spark/pull/31522#discussion_r673100605
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala
##########
@@ -183,14 +186,15 @@ class BasicWriteTaskStatsTracker(hadoopConf:
Configuration)
*/
class BasicWriteJobStatsTracker(
serializableHadoopConf: SerializableConfiguration,
- @transient val metrics: Map[String, SQLMetric])
+ @transient val driverSideMetrics: Map[String, SQLMetric],
+ taskCommitTimeMetric: SQLMetric)
extends WriteJobStatsTracker {
Review comment:
nit: seems we can simplify the caller side if we add a new constructor
in this class
```
def this(
serializableHadoopConf: SerializableConfiguration,
metrics: Map[String, SQLMetric]): WriteJobStatsTracker {
this(serializableHadoopConf, metrics - TASK_COMMIT_TIME,
metrics(TASK_COMMIT_TIME))
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
