cloud-fan commented on a change in pull request #31522:
URL: https://github.com/apache/spark/pull/31522#discussion_r674047852
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
##########
@@ -788,6 +792,28 @@ class SQLMetricsSuite extends SharedSparkSession with
SQLMetricsTestUtils
}
}
+ test("SPARK-34399: Add job commit duration metrics for DataWritingCommand") {
+ withSQLConf(SQLConf.FILE_COMMIT_PROTOCOL_CLASS.key ->
+ "org.apache.spark.sql.execution.metric.CustomFileCommitProtocol") {
+ withTable("t", "t2") {
+ sql("CREATE TABLE t(id STRING) USING PARQUET")
+ sql("INSERT INTO TABLE t SELECT 'abc'")
+ sql("INSERT INTO TABLE t SELECT 'abc'")
+ sql("INSERT INTO TABLE t SELECT 'abc'")
+ sql("CREATE TABLE t2(id STRING) USING PARQUET")
+ val df = sql("INSERT INTO TABLE t2 SELECT * FROM t")
Review comment:
can we simplify the test and just write `INSERT INTO TABLE t SELECT
'abc'`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
