xkrogen commented on a change in pull request #33116: URL: https://github.com/apache/spark/pull/33116#discussion_r674320231
########## File path: common/network-common/src/main/java/org/apache/spark/network/util/TimerWithCustomTimeUnit.java ########## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.network.util; + +import java.io.OutputStream; +import java.io.PrintWriter; +import java.util.concurrent.TimeUnit; + +import com.codahale.metrics.Snapshot; +import com.codahale.metrics.Timer; + +/** + * A custom version of a {@link Timer} which allows for specifying a specific {@link TimeUnit} to + * be used when accessing timing values via {@link #getSnapshot()}. Normally, though the + * {@link #update(long, TimeUnit)} method requires a unit, the extraction methods on the snapshot + * do not specify a unit, and always return nanoseconds. It can be useful to specify that a timer + * should use a different unit for its snapshot. Note that internally, all values are still stored + * with nanosecond-precision; it is only before being returned to the caller that the nanosecond + * value is converted to a millisecond value. Review comment: good catch, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
