xkrogen commented on a change in pull request #33116:
URL: https://github.com/apache/spark/pull/33116#discussion_r674322189
##########
File path:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleServiceMetrics.java
##########
@@ -84,13 +83,13 @@ public static void collectMetric(
.addGauge(new ShuffleServiceMetricsInfo(name + "_rateMean", "Mean rate
of timer " + name),
t.getMeanRate())
.addGauge(
- getShuffleServiceMetricsInfoForGenericValue(timingName, "max"),
snapshot.getMax())
+ getShuffleServiceMetricsInfoForGenericValue(name, "max"),
snapshot.getMax())
Review comment:
It would, yes, but the `Snapshot` portion of `Timer` metrics were only
exposed from `YarnShuffleServiceMetrics` starting after PR #32388 which hasn't
been released yet (slated for 3.2.0). Part of why I'd like to get this PR in
soon is to have it before 3.2.0 goes out, so that we can update these metric
names w/o worrying about compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
