shardulm94 commented on pull request #33446: URL: https://github.com/apache/spark/pull/33446#issuecomment-884554606
> Just wondering if we should log this for the push-merged meta request as well? Code [here](https://github.com/apache/spark/blob/c0d84e6cf1046b7944796038414ef21fe9c7e3b5/core/src/main/scala/org/apache/spark/storage/PushBasedFetchHelper.scala#L134) @otterc Added logging for this too. Thanks for the suggestion. @xkrogen In the current state of the PR, logging will only happen if the last request to be completed was successful. Should we instead add logging to both `onSuccess` and `onFailure`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
