otterc commented on a change in pull request #33446:
URL: https://github.com/apache/spark/pull/33446#discussion_r674411622



##########
File path: 
core/src/main/scala/org/apache/spark/storage/PushBasedFetchHelper.scala
##########
@@ -138,10 +140,19 @@ private class PushBasedFetchHelper(
         ((shuffleBlockId.shuffleId, shuffleBlockId.reduceId), size)
     }.toMap
     val address = req.address
+    var remainingBlockCount = sizeMap.size

Review comment:
       This I think is not needed. This is different from sending 
`FetchShuffleBlock` requests where multiple blockIds are included in a network 
request. For merged meta request, each network request is for just one meta 
request.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to