xkrogen commented on a change in pull request #33308:
URL: https://github.com/apache/spark/pull/33308#discussion_r674952903
##########
File path:
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSerdeSuite.scala
##########
@@ -86,18 +86,18 @@ class AvroSerdeSuite extends SparkFunSuite {
// deserialize should have no issues when 'bar' is nullable but fail when
it is nonnull
Deserializer.create(CATALYST_STRUCT, avro, BY_NAME)
assertFailedConversionMessage(avro, Deserializer, BY_NAME,
- "Cannot find non-nullable field 'foo.bar' (at position 0) in Avro
schema.",
+ "Cannot find field 'foo.bar' (at position 0) in Avro schema at field
'foo'",
nonnullCatalyst)
assertFailedConversionMessage(avro, Deserializer, BY_POSITION,
- "Cannot find non-nullable field at position 1 (field 'foo.baz') in Avro
schema.",
+ "Cannot find field at position 1 ('foo.baz') in Avro schema at field
'foo'",
Review comment:
Sorry I don't understand, are you saying you think the expected message
is incorrect? One thing to note is that this test is on `extraNonnullCatalyst`
as the Catalyst schema, whereas the previous test is on `nonnullCatalyst`. We
need an extra field because `CATALYST_STRUCT` and `nonnullCatalyst` have the
same field count as `avro`, so when doing `BY_POSITION` it will succeed. Thus
we use `extraNonnullCatalyst` which has an extra field `foo.baz` at position 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
