Ngone51 commented on a change in pull request #33340:
URL: https://github.com/apache/spark/pull/33340#discussion_r675272182
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockTransferor.java
##########
@@ -34,44 +34,44 @@
import org.apache.spark.network.util.TransportConf;
/**
- * Wraps another BlockFetcher with the ability to automatically retry fetches
which fail due to
- * IOExceptions, which we hope are due to transient network conditions.
+ * Wraps another BlockFetcher or BlockPusher with the ability to automatically
retry block
+ * transfers which fail due to IOExceptions, which we hope are due to
transient network conditions.
*
- * This fetcher provides stronger guarantees regarding the parent
BlockFetchingListener. In
+ * This transferor provides stronger guarantees regarding the parent
BlockTransferListener. In
* particular, the listener will be invoked exactly once per blockId, with a
success or failure.
*/
-public class RetryingBlockFetcher {
+public class RetryingBlockTransferor {
Review comment:
This's also public, although I have no idea how end-users could use it
directly.
Shall we mark it as private from now? cc @mridulm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
