Ngone51 commented on a change in pull request #33340:
URL: https://github.com/apache/spark/pull/33340#discussion_r675272626
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockTransferor.java
##########
@@ -213,28 +216,27 @@ public void onBlockFetchSuccess(String blockId,
ManagedBuffer data) {
// Now actually invoke the parent listener, outside of the synchronized
block.
if (shouldForwardSuccess) {
- listener.onBlockFetchSuccess(blockId, data);
+ listener.onBlockTransferSuccess(blockId, data);
}
}
- @Override
- public void onBlockFetchFailure(String blockId, Throwable exception) {
+ private void handleBlockTransferFailure(String blockId, Throwable
exception) {
// We will only forward this failure to our parent listener if this
block request is
// outstanding, we are still the active listener, AND we cannot retry
the fetch.
Review comment:
`retry the transfer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
