linhongliu-db commented on a change in pull request #33490:
URL: https://github.com/apache/spark/pull/33490#discussion_r676294216



##########
File path: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala
##########
@@ -289,6 +290,11 @@ class DateTimeUtilsSuite extends SparkFunSuite with 
Matchers with SQLHelper {
       checkStringToTimestamp("", None)
       checkStringToTimestamp("    ", None)
       checkStringToTimestamp("+", None)
+      checkStringToTimestamp("T", None)
+      checkStringToTimestamp("2015-03-18T", None)

Review comment:
       @srowen, thanks for reviewing. Personally I think it's invalid. But 
since previously it's allowed, so maybe someone will argue we should still 
allow it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to