Ngone51 commented on a change in pull request #33451:
URL: https://github.com/apache/spark/pull/33451#discussion_r676303864
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockStoreClient.java
##########
@@ -46,6 +46,43 @@
protected volatile TransportClientFactory clientFactory;
protected String appId;
+ protected TransportConf transportConf;
Review comment:
I tried to make all these three fields initialize in a constructor (it
seems a bit werid to me if we only try on `transportConf`) but failed due to
some dependency issue (because `clientFactory` can only be initialized after
`init()`). And there's not a few changes if we want to initialize
`transportConf ` in a constructor. So I finally decide to leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
