Ngone51 commented on a change in pull request #33451:
URL: https://github.com/apache/spark/pull/33451#discussion_r677410724
##########
File path:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
##########
@@ -834,17 +855,27 @@ final class ShuffleBlockFetcherIterator(
pushBasedFetchHelper.initiateFallbackFetchForPushMergedBlock(blockId, address)
// Set result to null to trigger another iteration of the
while loop.
result = null
- } else {
- if (buf.isInstanceOf[FileSegmentManagedBuffer]
- || corruptedBlocks.contains(blockId)) {
- throwFetchFailedException(blockId, mapIndex, address, e)
+ } else if (buf.isInstanceOf[FileSegmentManagedBuffer]) {
+ throwFetchFailedException(blockId, mapIndex, address, e)
+ } else if (corruptedBlocks.contains(blockId)) {
+ // It's the second time this block is detected corrupted
+ if (checksumEnabled) {
+ // Diagnose the cause of data corruption if shuffle
checksum is enabled
+ val cause = diagnoseCorruption(checkedIn, address, blockId)
+ buf.release()
+ val errorMsg = s"Block $blockId is corrupted due to
$cause."
Review comment:
good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
