HyukjinKwon commented on a change in pull request #33364:
URL: https://github.com/apache/spark/pull/33364#discussion_r677041374
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -1980,6 +1980,9 @@ def dropDuplicates(self, subset=None):
|Alice| 5| 80|
+-----+---+------+
"""
+ if subset is not None and not isinstance(subset, (list, tuple)):
Review comment:
Can we check if it's `Iterable` instead for now? Just in case it breaks
other user's apps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
