HyukjinKwon commented on a change in pull request #33364:
URL: https://github.com/apache/spark/pull/33364#discussion_r677324333
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -1980,6 +1981,11 @@ def dropDuplicates(self, subset=None):
|Alice| 5| 80|
+-----+---+------+
"""
+ if subset is not None and not isinstance(subset, Iterable):
+ raise TypeError("Parameter 'subset' must be a list of columns")
+ if subset is not None and isinstance(subset, str):
+ raise TypeError("Parameter 'subset' must be a list of columns")
Review comment:
oh, you changed. sorry for a back and forth. I think list and tuple
check was correct - I checked the py4j conversion logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
