Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5886#discussion_r29672166
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -82,6 +77,11 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
// List of application logs to be deleted by event log cleaner.
private var attemptsToClean = new
mutable.ListBuffer[FsApplicationAttemptInfo]
+ // Mapping of log file names to their last modified time. This is used
to ignore logs that
+ // are older during subsequent scans, to avoid processing data that is
already known.
+ @volatile private var lastModifiedTimes: mutable.LinkedHashMap[String,
Long]
--- End diff --
How about `scala.collection.concurrent.Map`? I think it's OK to allow that
a file might be updated just as it is deemed too old to care about. It will
just mean it is reprocessed next time, which is good. So just operation-level
synchronization is sufficient.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
